fix: apply CodeRabbit auto-fixes

This commit is contained in:
ZTatman 2026-11-20 16:56:32 -05:00
parent d192fe8f4d
commit 92a55ef31b
7 changed files with 45 additions and 21 deletions

View file

@ -72,7 +72,7 @@ Open `http://localhost:8000` in your browser. On first boot, Firebreak redirects
- **Forgejo instance URL** — use HTTPS unless Forgejo is a local service or loopback endpoint - **Forgejo instance URL** — use HTTPS unless Forgejo is a local service or loopback endpoint
- **OAuth credentials** — register an OAuth application in Forgejo first (Settings → Applications → Create OAuth2 Application), then paste the Client ID and Client Secret - **OAuth credentials** — register an OAuth application in Forgejo first (Settings → Applications → Create OAuth2 Application), then paste the Client ID and Client Secret
- **Public base URL** (optional) — your production domain for OAuth redirects - **Public base URL** (required) — confirm the pre-filled URL or replace it with the Firebreak URL you want to use for OAuth redirects
### 4. Sign In and Register Your Token ### 4. Sign In and Register Your Token

View file

@ -140,11 +140,11 @@ This file is the single source of truth for codebase obstacles, oddities, and th
**Solution/Workaround:** Resolved by migrating the web CSS build to pnpm (`@tailwindcss/cli`), which ships a normally signed binary. If the standalone binary is ever re-downloaded, fix with `xattr -c web/tailwindcss && codesign --force --sign - web/tailwindcss`. Diagnose this class of failure with `/usr/bin/log show --predicate 'eventMessage CONTAINS[c] "tailwind"'`. **Solution/Workaround:** Resolved by migrating the web CSS build to pnpm (`@tailwindcss/cli`), which ships a normally signed binary. If the standalone binary is ever re-downloaded, fix with `xattr -c web/tailwindcss && codesign --force --sign - web/tailwindcss`. Diagnose this class of failure with `/usr/bin/log show --predicate 'eventMessage CONTAINS[c] "tailwind"'`.
**Preference:** Prefer the pnpm-managed CLI; do not re-add the standalone binary. **Preference:** Prefer the pnpm-managed CLI; do not re-add the standalone binary.
### Tailwind `--watch` exits when stdin is closed ### Tailwind watcher can stop on stdin
**Area:** web/package.json (`css:watch` script) **Area:** web/dev.sh, web/package.json (`css:watch` script)
**Obstacle:** Tailwind v4 `--watch` keeps watching only while stdin is open. Under non-interactive shells and some CI contexts stdin closes immediately, so the watcher builds once, exits 0, and silently stops watching. This looks identical to a broken watcher and is easy to misdiagnose. **Obstacle:** With job control enabled, the background watcher can stop on SIGTTIN when bare `--watch` reads terminal stdin. With closed stdin it instead exits after the first build.
**Solution/Workaround:** No change needed for normal use — `dev.sh` backgrounds the watcher from an interactive terminal, which inherits an open stdin. If a caller needs watching without a tty, pass `--watch=always`. **Solution/Workaround:** Redirect the background watcher's stdin to `/dev/null` and use `--watch=always`. Keep process-group cleanup in `dev.sh`.
**Preference:** Use bare `--watch` for interactive dev; reserve `--watch=always` for headless callers. **Preference:** Keep the watcher independent of terminal input. For an isolated smoke check, run the installed CLI against temporary CSS rather than linking the workspace's `node_modules` into a separate pnpm project.
### pnpm install failed with exit 1 on blocked build scripts ### pnpm install failed with exit 1 on blocked build scripts
**Area:** pnpm-workspace.yaml **Area:** pnpm-workspace.yaml
@ -265,3 +265,9 @@ This file is the single source of truth for codebase obstacles, oddities, and th
**Obstacle:** Non-JSON responses or invalid JSON shapes raised outside the dashboard/picker's HTTP error boundary. Pydantic v2 also lets a validator's `TypeError` escape validation. **Obstacle:** Non-JSON responses or invalid JSON shapes raised outside the dashboard/picker's HTTP error boundary. Pydantic v2 also lets a validator's `TypeError` escape validation.
**Solution/Workaround:** Validate expected JSON shapes in the client, use `ValueError` for field validation, and return a sanitized 502 for malformed data. **Solution/Workaround:** Validate expected JSON shapes in the client, use `ValueError` for field validation, and return a sanitized 502 for malformed data.
**Preference:** Keep the dashboard and picker usable without displaying upstream response content. **Preference:** Keep the dashboard and picker usable without displaying upstream response content.
### Failed picker requests can reveal stale selections
**Area:** web/app/templates/dashboard.html, web/app/templates/snapshot_picker.html
**Obstacle:** HTMX clears its loading indicator after a failed request without replacing the old branch or commit controls.
**Solution/Workaround:** Mark the dependent fragment `inert` before sending a request and replace its outer element only when a response swaps. Show an inline error if the old fragment remains after loading.
**Preference:** Don't allow a stale selection to submit; preserve the dialog's layout during loading and failure.

View file

@ -534,16 +534,23 @@
align-content: start; align-content: start;
} }
.picker-load-scope > :is(.picker-loading, .picker-loaded) { .picker-load-scope > :is(.picker-loading, .picker-loaded, .picker-load-failed) {
grid-area: 1 / 1; grid-area: 1 / 1;
} }
.picker-loading, .picker-loading,
.picker-load-failed,
.picker-loaded[inert],
.picker-load-scope.htmx-request > .picker-loaded { .picker-load-scope.htmx-request > .picker-loaded {
visibility: hidden; visibility: hidden;
} }
.picker-load-scope.htmx-request > .picker-loading { .picker-loaded[inert] {
opacity: 0;
}
.picker-load-scope.htmx-request > .picker-loading,
.picker-load-scope:not(.htmx-request):has(> .picker-loaded[inert]) > .picker-load-failed {
visibility: visible; visibility: visible;
} }

View file

@ -61,6 +61,11 @@
</div> </div>
</div> </div>
</dialog> </dialog>
<script>
document.getElementById("snapshot-picker").addEventListener("htmx:beforeRequest", ({ detail: { target } }) => {
if (target.matches("#snapshot-branch-content, #snapshot-commit-content")) target.inert = true;
});
</script>
{% endif %} {% endif %}
<section class="grid gap-4 md:grid-cols-3"> <section class="grid gap-4 md:grid-cols-3">
<div class="p-4 card"> <div class="p-4 card">

View file

@ -13,7 +13,7 @@
hx-get="{{ url_for('get_snapshot_picker_step', step='branch').path }}" hx-get="{{ url_for('get_snapshot_picker_step', step='branch').path }}"
hx-trigger="change" hx-trigger="change"
hx-target="#snapshot-branch-content" hx-target="#snapshot-branch-content"
hx-swap="innerHTML" hx-swap="outerHTML"
hx-indicator="#snapshot-branch-scope" hx-indicator="#snapshot-branch-scope"
hx-sync="#snapshot-picker:replace"> hx-sync="#snapshot-picker:replace">
<button type="button"><selectedcontent></selectedcontent></button> <button type="button"><selectedcontent></selectedcontent></button>
@ -25,8 +25,11 @@
</div> </div>
<div id="snapshot-branch-scope" class="picker-load-scope"> <div id="snapshot-branch-scope" class="picker-load-scope">
<p class="picker-status picker-loading" role="status">Loading branches…</p> <p class="picker-status picker-loading" role="status">Loading branches…</p>
<div id="snapshot-branch-content" class="picker-loaded"> <p class="picker-status picker-load-failed" role="status" data-state="error">
{% block branch_steps %} Could not load branches. Choose a repository again or reopen the picker.
</p>
{% block branch_steps %}
<div id="snapshot-branch-content" class="picker-loaded">
<div class="picker-step"> <div class="picker-step">
<span class="picker-step-index" aria-hidden="true">2</span> <span class="picker-step-index" aria-hidden="true">2</span>
<div> <div>
@ -40,7 +43,7 @@
hx-trigger="change" hx-trigger="change"
hx-include="#snapshot-repository" hx-include="#snapshot-repository"
hx-target="#snapshot-commit-content" hx-target="#snapshot-commit-content"
hx-swap="innerHTML" hx-swap="outerHTML"
hx-indicator="#snapshot-commit-scope" hx-indicator="#snapshot-commit-scope"
hx-sync="#snapshot-picker:replace"> hx-sync="#snapshot-picker:replace">
<button type="button"><selectedcontent></selectedcontent></button> <button type="button"><selectedcontent></selectedcontent></button>
@ -60,7 +63,7 @@
hx-get="{{ url_for('get_snapshot_picker_step', step='branch').path }}" hx-get="{{ url_for('get_snapshot_picker_step', step='branch').path }}"
hx-include="#snapshot-repository" hx-include="#snapshot-repository"
hx-target="#snapshot-branch-content" hx-target="#snapshot-branch-content"
hx-swap="innerHTML" hx-swap="outerHTML"
hx-indicator="#snapshot-branch-scope" hx-indicator="#snapshot-branch-scope"
hx-sync="#snapshot-picker:replace">Retry</button> hx-sync="#snapshot-picker:replace">Retry</button>
{% endif %} {% endif %}
@ -72,8 +75,11 @@
</div> </div>
<div id="snapshot-commit-scope" class="picker-load-scope"> <div id="snapshot-commit-scope" class="picker-load-scope">
<p class="picker-status picker-loading" role="status">Loading commits…</p> <p class="picker-status picker-loading" role="status">Loading commits…</p>
<div id="snapshot-commit-content" class="picker-loaded"> <p class="picker-status picker-load-failed" role="status" data-state="error">
{% block commit_step %} Could not load commits. Choose a branch again or reopen the picker.
</p>
{% block commit_step %}
<div id="snapshot-commit-content" class="picker-loaded">
<div class="picker-step"> <div class="picker-step">
<span class="picker-step-index" aria-hidden="true">3</span> <span class="picker-step-index" aria-hidden="true">3</span>
<div> <div>
@ -115,11 +121,11 @@
{% endif %} {% endif %}
</div> </div>
</div> </div>
{% endblock %} </div>
</div> {% endblock %}
</div> </div>
{% endblock %} </div>
</div> {% endblock %}
</div> </div>
{% endblock %} {% endblock %}
<!-- djlint:on --> <!-- djlint:on -->

View file

@ -19,7 +19,7 @@ echo " PostgreSQL / db / firebreak / firebreak / firebreak_db"
echo " CSS: watching app/static/css/input.css" echo " CSS: watching app/static/css/input.css"
set -m set -m
pnpm run css:watch & pnpm run css:watch </dev/null &
TW_PID=$! TW_PID=$!
set +m set +m

View file

@ -4,7 +4,7 @@
"version": "0.1.0", "version": "0.1.0",
"scripts": { "scripts": {
"css": "tailwindcss -i ./app/static/css/input.css -o ./app/static/css/output.css", "css": "tailwindcss -i ./app/static/css/input.css -o ./app/static/css/output.css",
"css:watch": "tailwindcss -i ./app/static/css/input.css -o ./app/static/css/output.css --watch" "css:watch": "tailwindcss -i ./app/static/css/input.css -o ./app/static/css/output.css --watch=always"
}, },
"devDependencies": { "devDependencies": {
"@tailwindcss/cli": "4.3.0" "@tailwindcss/cli": "4.3.0"