Replace manual .env configuration with a browser-based setup wizard. New users deploy with `docker compose up` and configure Forgejo OAuth credentials through /setup on first visit. Existing users can reconfigure via the same page (auth-gated post-setup). Key changes: Rename (Myst → Firebreak): - Config fields, env vars, session cookie, templates, docker-compose, README all renamed from Myst to Firebreak Setup wizard (/setup): - New AppSettings single-row DB table stores Forgejo config - Auto-generates Fernet encryption key on first setup - SetupRequiredMiddleware redirects all routes to /setup pre-config - Reconfigure mode pre-fills existing values, requires auth - Landing page links to /setup for recovery if OAuth breaks Settings page (/settings): - PAT registration moved out of dashboard into dedicated page - Token card with registration date, delete, and update actions - Dashboard shows CTA linking to settings when no PAT registered Auth updates: - Routes use AppSettings from DB instead of env-based Settings - OAuth callback redirects new users to /settings for PAT setup - Forgejo API errors no longer leak upstream response bodies - Decrypt failures return actionable 503 instead of unhandled 500 Code quality: - Extracted templating.py to eliminate circular import hacks - AppSettings.get_fernet() caches Fernet cipher instance - User.has_pat property replaces scattered None checks - lookup_session promoted to public API - Dead code removed, return type annotations added - PAT input fields use type="password" - CSRF gap documented in agents.md for future addressing Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
76 lines
2.4 KiB
Python
76 lines
2.4 KiB
Python
from __future__ import annotations
|
|
|
|
from datetime import UTC, datetime
|
|
from typing import Annotated
|
|
|
|
from fastapi import APIRouter, Depends, Form, HTTPException, Request, status
|
|
from fastapi.responses import HTMLResponse, RedirectResponse
|
|
from sqlalchemy.ext.asyncio import AsyncSession
|
|
|
|
from app.auth.crypto import encrypt_optional
|
|
from app.auth.session import get_current_session
|
|
from app.config import get_app_settings
|
|
from app.deps import get_db
|
|
from app.models.app_settings import AppSettings
|
|
from app.models.session import Session as UserBrowserSession
|
|
from app.templating import templates
|
|
|
|
router = APIRouter(prefix="/settings", tags=["settings"])
|
|
|
|
|
|
@router.get("", response_class=HTMLResponse)
|
|
async def settings_page(
|
|
request: Request,
|
|
sess: Annotated[UserBrowserSession, Depends(get_current_session)],
|
|
app_settings: Annotated[AppSettings, Depends(get_app_settings)],
|
|
) -> HTMLResponse:
|
|
return templates.TemplateResponse(
|
|
request,
|
|
"settings.html",
|
|
{
|
|
"user": sess.user,
|
|
"pat_registered": sess.user.has_pat,
|
|
"pat_registered_at": sess.user.pat_registered_at,
|
|
"pat_deleted": request.query_params.get("pat") == "deleted",
|
|
},
|
|
)
|
|
|
|
|
|
@router.post("/pat")
|
|
async def register_pat(
|
|
pat: Annotated[str, Form()],
|
|
db: Annotated[AsyncSession, Depends(get_db)],
|
|
app_settings: Annotated[AppSettings, Depends(get_app_settings)],
|
|
sess: Annotated[UserBrowserSession, Depends(get_current_session)],
|
|
) -> RedirectResponse:
|
|
pat = pat.strip()
|
|
if not pat:
|
|
raise HTTPException(
|
|
status_code=status.HTTP_400_BAD_REQUEST,
|
|
detail="Forgejo access token is required.",
|
|
)
|
|
|
|
fernet = app_settings.get_fernet()
|
|
sess.user.pat_encrypted = encrypt_optional(fernet, pat)
|
|
sess.user.pat_registered_at = datetime.now(UTC)
|
|
await db.commit()
|
|
|
|
return RedirectResponse(
|
|
"/settings?pat=registered",
|
|
status_code=status.HTTP_303_SEE_OTHER,
|
|
)
|
|
|
|
|
|
@router.post("/pat/delete")
|
|
async def delete_pat(
|
|
db: Annotated[AsyncSession, Depends(get_db)],
|
|
sess: Annotated[UserBrowserSession, Depends(get_current_session)],
|
|
) -> RedirectResponse:
|
|
sess.user.pat_encrypted = None
|
|
sess.user.pat_registered_at = None
|
|
await db.commit()
|
|
|
|
return RedirectResponse(
|
|
"/settings?pat=deleted",
|
|
status_code=status.HTTP_303_SEE_OTHER,
|
|
)
|