firebreak/web/app/routers/settings.py
ZTatman 18897362df fix(web): security hardening, rename cleanup, and error pages
- Move TOKEN_ENCRYPTION_KEY from DB to env var (no longer stored alongside encrypted data)
- Add one-time setup token printed to server logs to prevent anonymous setup takeover
- Setup token persists until first successful login, allowing config retries
- Remove setup_complete flag in favor of app_settings nullability check
- Fix stale Myst→Firebreak references in crypto.py, dev.sh, pyproject.toml
- Add dynamic OAuth callback URL in setup wizard
- Fix global heading color override to use foreground instead of danger
- Add aria-label to brand link for accessibility
- Remove forced redirect to /settings after first login
- Remove reconfigure link from landing page
- Add styled error page with HTML/JSON content negotiation
- Add 401 guard dog easter egg

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
2026-06-05 00:27:51 -04:00

73 lines
2.2 KiB
Python

from __future__ import annotations
from datetime import UTC, datetime
from typing import Annotated
from fastapi import APIRouter, Depends, Form, HTTPException, Request, status
from fastapi.responses import HTMLResponse, RedirectResponse
from sqlalchemy.ext.asyncio import AsyncSession
from app.auth.crypto import encrypt_optional
from app.auth.session import get_current_session
from app.config import get_fernet
from app.deps import get_db
from app.models.session import Session as UserBrowserSession
from app.templating import templates
router = APIRouter(prefix="/settings", tags=["settings"])
@router.get("", response_class=HTMLResponse)
async def settings_page(
request: Request,
sess: Annotated[UserBrowserSession, Depends(get_current_session)],
) -> HTMLResponse:
return templates.TemplateResponse(
request,
"settings.html",
{
"user": sess.user,
"pat_registered": sess.user.has_pat,
"pat_registered_at": sess.user.pat_registered_at,
"pat_deleted": request.query_params.get("pat") == "deleted",
},
)
@router.post("/pat")
async def register_pat(
pat: Annotated[str, Form()],
db: Annotated[AsyncSession, Depends(get_db)],
sess: Annotated[UserBrowserSession, Depends(get_current_session)],
) -> RedirectResponse:
pat = pat.strip()
if not pat:
raise HTTPException(
status_code=status.HTTP_400_BAD_REQUEST,
detail="Forgejo access token is required.",
)
fernet = get_fernet()
sess.user.pat_encrypted = encrypt_optional(fernet, pat)
sess.user.pat_registered_at = datetime.now(UTC)
await db.commit()
return RedirectResponse(
"/settings?pat=registered",
status_code=status.HTTP_303_SEE_OTHER,
)
@router.post("/pat/delete")
async def delete_pat(
db: Annotated[AsyncSession, Depends(get_db)],
sess: Annotated[UserBrowserSession, Depends(get_current_session)],
) -> RedirectResponse:
sess.user.pat_encrypted = None
sess.user.pat_registered_at = None
await db.commit()
return RedirectResponse(
"/settings?pat=deleted",
status_code=status.HTTP_303_SEE_OTHER,
)